server : Add option to return token pieces in /tokenize endpoint #9108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Aug 21, 2024
ngxson
requested changes
Aug 21, 2024
|
Also, this will fail if one of the pieces has incomplete unicode bytes. For example: Response: |
For the case that a piece is invalid utf8 I have added a fallback where a list of bytes will be sent instead. |
github-actions
bot
added
the
devops
|
ping @ngxson |
ngxson
approved these changes
Aug 27, 2024
mofosyne
added
the
Review Complexity : Low
|
@mathijshenquet Sorry for the delay. Let's resolve the conflict and merge. |
|
I merged with upstream master. That should fix the CI problem. (Let's merge once CI passes) |
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
…rganov#9108) * server : added with_pieces functionality to /tokenize endpoint * server : Add tokenize with pieces tests to server.feature * Handle case if tokenizer splits along utf8 continuation bytes * Add example of token splitting * Remove trailing ws * Fix trailing ws * Maybe fix ci * maybe this fix windows ci? --------- Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
…rganov#9108) * server : added with_pieces functionality to /tokenize endpoint * server : Add tokenize with pieces tests to server.feature * Handle case if tokenizer splits along utf8 continuation bytes * Add example of token splitting * Remove trailing ws * Fix trailing ws * Maybe fix ci * maybe this fix windows ci? --------- Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
…rganov#9108) * server : added with_pieces functionality to /tokenize endpoint * server : Add tokenize with pieces tests to server.feature * Handle case if tokenizer splits along utf8 continuation bytes * Add example of token splitting * Remove trailing ws * Fix trailing ws * Maybe fix ci * maybe this fix windows ci? --------- Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
/tokenizeendpoint by adding an option to return token pieces along with their IDs. This feature allows users to easily understand what each token represents without needing to make additional API calls or perform client-side lookups.Motivation
Often, users want to know not just the token IDs but also what these tokens represent in the original text. Previously, this required either inefficient additional API calls or complex client-side logic. This change makes it much easier and more efficient to get this information in a single request.
Changes
with_piecesboolean parameter to the/tokenizeendpoint.with_piecesis true, the response includes both token IDs and their corresponding pieces.with_piecesis not specified or is false, the endpoint behaves as before.Testing
Documentation
Updated the API documentation to include the new
with_piecesparameter and to show example responses for both cases (with and without pieces).NB: I wasn't able to run the CI pipeline locally as I'm currently on Windows.